Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(edgeless): new note slicer #6029

Merged

Conversation

donteatfriedrice
Copy link
Member

@donteatfriedrice donteatfriedrice commented Jan 18, 2024

TOV-191

New note slicer:

  • Add a cutting mode button on note toolbar to be used to toggle note slicer setting and store it in session storage.
Screenshot 2024-01-19 at 02 48 47
  • Update slicer button ui style and position.
  • Change slice indicator to block dividing lines. And active line will be shown with animation.
Screenshot 2024-01-19 at 15 00 39
  • The note cut will inherit the properties of last note.
Screen.Recording.2024-01-19.at.02.50.02.mov
  • Add shortcut '-' for cutting mode. When select one note, press '-' can toggle cutting mode

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 10:06am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs-main ⬜️ Ignored (Inspect) Visit Preview Jan 19, 2024 10:06am

@donteatfriedrice donteatfriedrice marked this pull request as draft January 18, 2024 16:15
@hwangdev97
Copy link
Member

maybe the button should be align with the dosh line ? cc @zanwei

shot-2024-01-19-14 35 06@2x

@Svaney-ssman
Copy link

Should the note exit cutting mode after the user click outside the note or do other operations? @hwangdev97 @zanwei

@zanwei
Copy link
Member

zanwei commented Jan 19, 2024

Had a discussion internally, there're few changes need to be modified.

  1. After the user cuts the note, the cut mode will not be saved.
  2. We gonna add a shortcut to active the cut mode easily.
  3. Drag handle should be disabled when cut mode is activated.

cc @donteatfriedrice

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the feat!

@donteatfriedrice donteatfriedrice enabled auto-merge (squash) January 19, 2024 10:04
@donteatfriedrice donteatfriedrice merged commit ee90694 into toeverything:master Jan 19, 2024
19 of 20 checks passed
@donteatfriedrice donteatfriedrice deleted the feat/note-slicer branch January 19, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable Major improvement worth emphasizing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants