Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attachment block should not contenteditable #6064

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

Flrande
Copy link
Member

@Flrande Flrande commented Jan 22, 2024

No description provided.

@Flrande Flrande enabled auto-merge (squash) January 22, 2024 08:16
Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 8:18am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs-main ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 8:18am

Copy link
Member

@lawvs lawvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think declaring the property directly is also a good pattern.

  override readonly contentEditable = 'false';

@Flrande Flrande merged commit 5335e1c into master Jan 22, 2024
20 checks passed
@Flrande Flrande deleted the flrande/fix/attach-0122 branch January 22, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants