Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support edgeless-attachment & card views #6069

Merged
merged 12 commits into from
Jan 24, 2024
Merged

feat: support edgeless-attachment & card views #6069

merged 12 commits into from
Jan 24, 2024

Conversation

AyushAgrawal-A2
Copy link
Contributor

@AyushAgrawal-A2 AyushAgrawal-A2 commented Jan 22, 2024 •
edited

closes #5996

Changes:

  • Added support for attachment block in edgeless (in surface)
  • Implemented card view for attachment block (doc & edgeless)
  • Updated edgeless toolbar for attachment block
  • Drag & drop from note to surface & vice-versa
  • File drop (all files except images) in edgeless page will create attachment cards
  • Copy-Pasting files (all except images) in edgeless page will create attachment cards

Pending (to be done in another PR):

  • Unsynced status logic ???
  • Copy-Pasting files (all except images) in doc page to create attachment cards, cc @fourdim
  • Toolbar update as per new design (doc & edgeless), cc @Svaney-ssman
  • File preview, cc @Svaney-ssman

@vercel Vercel
Copy link

vercel bot commented Jan 22, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 7:00am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs-main ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 7:00am

@AyushAgrawal-A2 AyushAgrawal-A2 marked this pull request as draft January 22, 2024 15:29
@AyushAgrawal-A2 AyushAgrawal-A2 changed the title feat: edgeless-attachment & card views feat: support edgeless-attachment & card views Jan 23, 2024
Svaney-ssman
Svaney-ssman reviewed Jan 24, 2024
View reviewed changes
Copy link

@Svaney-ssman Svaney-ssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All look good, except the edgeless toolbar needs updating, plz 1. change the link icon, 2. add a attachment icon. Design is updated here
image

@houjoe0829
Copy link

  • The entry to add files is missing on the Edgeless Toolbar. cc @Svaney-ssman
  • Some options are missing on the Elements Toolbar, such as Rename and Download. cc @Svaney-ssman

@Svaney-ssman
Copy link

  • The entry to add files is missing on the Edgeless Toolbar. cc @Svaney-ssman
  • Some options are missing on the Elements Toolbar, such as Rename and Download. cc @Svaney-ssman

@AyushAgrawal-A2 will renovate toolbar issues in next pr

@AyushAgrawal-A2 AyushAgrawal-A2 marked this pull request as ready for review January 24, 2024 05:01
Svaney-ssman
Svaney-ssman approved these changes Jan 24, 2024
View reviewed changes
Copy link

@Svaney-ssman Svaney-ssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doodlewind doodlewind added the notable Major improvement worth emphasizing label Jan 24, 2024
doodlewind
doodlewind approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feat!

@doodlewind doodlewind merged commit d6a8463 into toeverything:master Jan 24, 2024
19 checks passed
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the ayush/5996 branch January 24, 2024 18:02
@fourdim fourdim mentioned this pull request Jan 25, 2024
Merged
This was referenced Jan 29, 2024
Closed
Closed
@joooye34 joooye34 mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

@Svaney-ssman Svaney-ssman Svaney-ssman approved these changes

@hwangdev97 hwangdev97 Awaiting requested review from hwangdev97

@doouding doouding Awaiting requested review from doouding

@Flrande Flrande Awaiting requested review from Flrande

Assignees

@AyushAgrawal-A2 AyushAgrawal-A2

Labels
notable Major improvement worth emphasizing
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Attachment card view
5 participants
@AyushAgrawal-A2 @houjoe0829 @Svaney-ssman @doodlewind @Flrande