Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(edgeless): bugs of connector and block #6088

Merged
merged 12 commits into from
Jan 24, 2024
Merged

fix(edgeless): bugs of connector and block #6088

merged 12 commits into from
Jan 24, 2024

Conversation

doouding
Copy link
Member

@doouding doouding commented Jan 23, 2024 •
edited

  • Defer the connectors' path updating to avoid double calculation
  • Call mount after creating models
  • Connectors' path should be updated when the xywh prop gets updated.
  • Prevent pop from writing value to the ymap when the property is a local one
  • Emit event in block observeDeep

@vercel Vercel
Copy link

vercel bot commented Jan 23, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 3:05am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs-main ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 3:05am

@doouding doouding changed the title refactor(edgeless): should call mount after creating the model fix(edgeless): should call mount after creating the model Jan 23, 2024
@doouding doouding changed the title fix(edgeless): should call mount after creating the model fix(edgeless): bugs of connectors and block Jan 24, 2024
@doouding doouding changed the title fix(edgeless): bugs of connectors and block fix(edgeless): bugs of connector and block Jan 24, 2024
@doouding doouding marked this pull request as ready for review January 24, 2024 03:14
@doodlewind doodlewind merged commit 6169b3d into master Jan 24, 2024
21 checks passed
@doodlewind doodlewind deleted the fix/connector branch January 24, 2024 04:08
@joooye34 joooye34 mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

@Saul-Mirone Saul-Mirone Awaiting requested review from Saul-Mirone

Assignees

@doouding doouding

Labels
None yet
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doouding @doodlewind