Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bookmark and image block should not contenteditable #6089

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

Flrande
Copy link
Member

@Flrande Flrande commented Jan 23, 2024

No description provided.

@Flrande Flrande enabled auto-merge (squash) January 23, 2024 13:09
Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 1:14pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs-main ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2024 1:14pm

@Flrande Flrande changed the title fix: bookmark block should not contenteditable fix: bookmark and image block should not contenteditable Jan 23, 2024
@Flrande Flrande merged commit 02f373e into master Jan 24, 2024
20 checks passed
@Flrande Flrande deleted the flrande/fix/bookmark-0123 branch January 24, 2024 04:10
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this can be pre-defined in the createEmbedBlock helper @Saul-Mirone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants