fix(presets): no frame preview in sidebar #6124
Conversation
donteatfriedrice
requested review from
Saul-Mirone and
doodlewind
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
donteatfriedrice
changed the title
| @@ -182,7 +182,7 @@ export class FramePanelHeader extends WithDisposable(LitElement) { | |||
| this._settingPopperShow = display === 'show'; | |||
| }, | |||
| 14, | |||
| -120 | |||
There was a problem hiding this comment.
Is this modification made to solve the TOV-487 issue? It seems to have shifted only a few pixels. In AFFiNE, this panel is set to overflow:hidden, can Blocksuite mount the Popup to the body instead?
There was a problem hiding this comment.
The frame panel setting popup seems not to be hidden. This line is just used to adjust the position.
There was a problem hiding this comment.
It may be clipped in AFFiNE, I think it's better to mount Popup under body if it's supported in blocksuite.
There was a problem hiding this comment.
OK, I'll check whether can mount the panel Popup under body.
I'll add some later. |
To fix:
TOV-487
TOV-489
Screen.Recording.2024-01-26.at.02.21.15.mov
Todo: