Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(edgeless): template and surface-ref bug #6161

Merged
merged 2 commits into from
Jan 31, 2024
Merged

fix(edgeless): template and surface-ref bug #6161

merged 2 commits into from
Jan 31, 2024

Conversation

doouding
Copy link
Member

  • Add basic test for template
  • Fix surface-ref slot is not disposed correctly

@vercel Vercel
Copy link

vercel bot commented Jan 31, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 7:28am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 7:28am

@doouding doouding marked this pull request as ready for review January 31, 2024 07:34
@doodlewind doodlewind merged commit daf748a into master Jan 31, 2024
21 checks passed
@doodlewind doodlewind deleted the fix/edgeless-bugs branch January 31, 2024 08:32
@doouding doouding mentioned this pull request Feb 1, 2024
Closed
@Brooooooklyn Brooooooklyn mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

Assignees

@doouding doouding

Labels
None yet
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doouding @doodlewind