Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(page): delete block when deleting the last database view #6174

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

lawvs
Copy link
Member

@lawvs lawvs commented Feb 1, 2024

Fix #6071

This pull request fixes an issue where the last database view was not being deleted properly.

Before

Screen.Recording.2024-02-01.at.15.38.12.mov

Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 7:39am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 7:39am

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doodlewind doodlewind merged commit 6fcb96f into master Feb 1, 2024
22 checks passed
@doodlewind doodlewind deleted the fix/remove-block-when-delete-last-database-view branch February 1, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Error occurred when deleting the only database view
2 participants