Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: arrow buttons are disabled when kanban exists in page #6248

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

ununian
Copy link
Contributor

@ununian ununian commented Feb 20, 2024

iShot_2024-02-20_16 56 02

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 1:23pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 1:23pm

@ununian
Copy link
Contributor Author

ununian commented Feb 20, 2024

@doodlewind please cc

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the CLA.md? Thanks!

@ununian ununian changed the title fix: Arrow buttons are disabled when Page has a kanban block. fix: arrow buttons are disabled when Page has a kanban block. Feb 20, 2024
@ununian
Copy link
Contributor Author

ununian commented Feb 20, 2024

Could you update the CLA.md? Thanks!

done!

@doodlewind doodlewind changed the title fix: arrow buttons are disabled when Page has a kanban block. fix: arrow buttons are disabled when kanban exists in page Feb 20, 2024
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome and thanks again for the fix!

@doodlewind doodlewind enabled auto-merge (squash) February 20, 2024 21:52
@doodlewind doodlewind merged commit e4eaf40 into toeverything:master Feb 20, 2024
18 of 20 checks passed
fundon pushed a commit to fundon/blocksuite that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants