Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add context in command result #6265

Merged
merged 3 commits into from
Feb 22, 2024
Merged

feat: add context in command result #6265

merged 3 commits into from
Feb 22, 2024

Conversation

Saul-Mirone
Copy link
Collaborator

No description provided.

@vercel Vercel
Copy link

vercel bot commented Feb 22, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 3:04am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 3:04am

@Saul-Mirone Saul-Mirone marked this pull request as ready for review February 22, 2024 02:49
@doodlewind doodlewind added breaking Contains breaking change that must be addressed notable Major improvement worth emphasizing labels Feb 22, 2024
doodlewind
doodlewind approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think this can be used to avoid previous pattern to pass context content via side effect assign in closure? Some code pattern can be migrated in this case.

@Saul-Mirone
Copy link
Collaborator Author

Saul-Mirone commented Feb 22, 2024 •
edited

So I think this can be used to avoid previous pattern to pass context content via side effect assign in closure? Some code pattern can be migrated in this case.

Yeah, we can get it from result now.

@Saul-Mirone Saul-Mirone enabled auto-merge (squash) February 22, 2024 02:55
@Saul-Mirone Saul-Mirone enabled auto-merge (squash) February 22, 2024 02:57
@Saul-Mirone Saul-Mirone merged commit 61fb40e into toeverything:master Feb 22, 2024
18 of 19 checks passed
@Saul-Mirone Saul-Mirone deleted the add-ctx-for-command-result branch February 22, 2024 07:02
@AyushAgrawal-A2 AyushAgrawal-A2 mentioned this pull request Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

Assignees

@Saul-Mirone Saul-Mirone

Labels
breaking Contains breaking change that must be addressed notable Major improvement worth emphasizing
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Saul-Mirone @doodlewind