-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(edgeless): fix laggy selection & legacy template rendering #6341
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate about how the multi-selection is optimized and how is the measured result? Thanks.
It's weird that I haven't observed the laggy case in the windows laptop in current master, so the perf update could really be subjective for the moment.
Well, I recorded the performance of the multi-selection action and eliminated the unnecessary render and computation during the action to reduce the frame times. It may still take some time with CPU 6x slow down, but it's better than before optimization. But like you said, the next step that needs to be done more than anything else is a stable performance metrics testing. |
Change
walk
into transformerJob
to traverse a template (use to modify the snapshot content before importing start)watch
decorator to watch element property changecommands
to brush to avoid double computation