-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(edgeless): last selection was recovered unexpected after panning from default tool #6343
fix(edgeless): last selection was recovered unexpected after panning from default tool #6343
Conversation
…from default tool
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you sign the CLA.md? Thanks!
…b.com/congzhou09/blocksuite into fix/last-selection-recover-unexpected
done. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks!
edgeless problem:
As demonstrated in the video below, when using default tool, I clicked on blank region and the selection is cleared right , but then, after panning, the last selection was recovered unexpected.
problem.mp4
fixed as follows:
Before changing default tool to panning tool, clear the last-selection if there's no selection. Thus unexpected last-selection will not be recovered.
fix.mp4