fix(page): handle delete or backspace align with embed block #6364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
doodlewind
requested changes
Mar 4, 2024
It seems that we can not directly pass 'affine:embed-' to matchFlavours since the expected parameter Key should be a type extending (keyof BlockSuite.BlockModels)[]. But pattern like 'affine:embed-' is not a key of BlockSuite.BlockModels. Should we relax the type restrictions of functions, such as changing key to string type? |
|
Is it possible to use template literal type here? But based on current type check state, this PR should also be fine to land. |
doodlewind
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close #6327
Forward delete before embed block will be ignored.
Pressing backspace when adjacent to an embed block will select the embed block.