Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(page): skip adding reference node when importing notion zip #6376

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix(page): skip adding reference node when importing notion zip #6376

merged 2 commits into from
Mar 5, 2024

Conversation

fourdim
Copy link
Contributor

@fourdim fourdim commented Mar 5, 2024

This commit will break AFFiNE as showImportModal is referenced in AFFiNE.

export type OnSuccessHandler = (
  pageIds: string[],
-  isWorkspaceFile: boolean
+  options: { isWorkspaceFile: boolean; importedCount: number }
) => void;

A fix will be introduced to AFFiNE later.

@fourdim fourdim requested a review from doodlewind March 5, 2024 03:55
@vercel Vercel
Copy link

vercel bot commented Mar 5, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 4:07am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2024 4:07am

@doodlewind doodlewind added the breaking Contains breaking change that must be addressed label Mar 5, 2024
doodlewind
doodlewind approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fourdim fourdim merged commit da781df into toeverything:master Mar 5, 2024
19 checks passed
@doouding doouding mentioned this pull request Mar 5, 2024
Merged
Brooooooklyn pushed a commit to toeverything/AFFiNE that referenced this pull request Mar 5, 2024
@doouding
feat: bump blocksuite (#6015)
5bebcec 
## Features
- toeverything/blocksuite#6379 @doodlewind
- toeverything/blocksuite#6375 @doodlewind
- toeverything/blocksuite#6370 @donteatfriedrice

## Bugfix
- toeverything/blocksuite#6380 @donteatfriedrice
- toeverything/blocksuite#6377 @doouding
- toeverything/blocksuite#6376 @fourdim
- toeverything/blocksuite#6374 @regischen

## Misc
- docs: update examples desc
- ci: start publishing 0.13 canary
@fourdim fourdim deleted the batch-fix branch April 16, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

Assignees

@fourdim fourdim

Labels
breaking Contains breaking change that must be addressed
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fourdim @doodlewind