Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add text style commands #6406

Merged
merged 2 commits into from
Mar 6, 2024
Merged

feat: add text style commands #6406

merged 2 commits into from
Mar 6, 2024

Conversation

Saul-Mirone
Copy link
Collaborator

No description provided.

@vercel Vercel
Copy link

vercel bot commented Mar 6, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 5:32am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 5:32am

@Saul-Mirone Saul-Mirone marked this pull request as ready for review March 6, 2024 04:50
doodlewind
doodlewind reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to expose these commands in the doc site? Try running the docs package locally and you can see the typing of commands seems to be missing in typedoc.

@Saul-Mirone
Copy link
Collaborator Author

How to expose these commands in the doc site? Try running the docs package locally and you can see the typing of commands seems to be missing in typedoc.

Added

@doodlewind doodlewind added the notable Major improvement worth emphasizing label Mar 6, 2024
@doodlewind doodlewind merged commit 6d6537b into toeverything:master Mar 6, 2024
19 checks passed
@Saul-Mirone Saul-Mirone deleted the text-style-commands branch March 6, 2024 05:37
@regischen regischen mentioned this pull request Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

Assignees

@Saul-Mirone Saul-Mirone

Labels
notable Major improvement worth emphasizing
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Saul-Mirone @doodlewind