Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edgeless): paste group with same relative index #6415

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

regischen
Copy link
Member

@regischen regischen commented Mar 6, 2024

Close #6242

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 8:45am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 8:45am

@doouding
Copy link
Member

Remapping element index is a common use case (also used in edgeless template inserting). Extending the original compare function to accept an index map rather than reimplementing it would be great. But it is ok to do this later.

@regischen regischen merged commit d1bc142 into master Mar 12, 2024
19 checks passed
@regischen regischen deleted the fix-group-paste-index branch March 12, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

​Copy paste a group in edgeless mode doesn't not create the result expected
2 participants