Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(page): image not found after import notion file #6419

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

zkwolf
Copy link
Contributor

@zkwolf zkwolf commented Mar 6, 2024

Fix #6038

Add assets to store images and add image proxy worker to avoid CORS.

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 2:28pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 2:28pm

@Jycreyn
Copy link

Jycreyn commented Mar 6, 2024

Uh, sorry don't understand ?

It's a bug or i need to do something ?

@fourdim fourdim merged commit 20bb7d4 into toeverything:master Mar 6, 2024
20 checks passed
@fourdim
Copy link
Contributor

fourdim commented Mar 6, 2024

Uh, sorry don't understand ?

It's a bug or i need to do something ?

Yes, it's a bug.

@Jycreyn
Copy link

Jycreyn commented Mar 6, 2024

Uh, sorry don't understand ?
It's a bug or i need to do something ?

Yes, it's a bug.

Uhm, okay and there is a solution ? (thanks for this project it's awesome)

@fourdim
Copy link
Contributor

fourdim commented Mar 6, 2024

Uh, sorry don't understand ?
It's a bug or i need to do something ?

Yes, it's a bug.

Uhm, okay and there is a solution ? (thanks for this project it's awesome)

It's fixed by this pull request.

@Jycreyn
Copy link

Jycreyn commented Mar 6, 2024

Okay, uhm.

I'm using affine with docker compose.
I have " image: ghcr.io/toeverything/affine-graphql:stable " in my docker compose.

Seems it's not working after a re-deploy.

Maybe it's not the right way.

Thanks for you'r help

@fourdim
Copy link
Contributor

fourdim commented Mar 6, 2024

Okay, uhm.

I'm using affine with docker compose. I have " image: ghcr.io/toeverything/affine-graphql:stable " in my docker compose.

Seems it's not working after a re-deploy.

Maybe it's not the right way.

Thanks for you'r help

It will be fixed in the next major/minor (idk) release of AFFiNE.

@Jycreyn
Copy link

Jycreyn commented Mar 6, 2024

Okay, uhm.
I'm using affine with docker compose. I have " image: ghcr.io/toeverything/affine-graphql:stable " in my docker compose.
Seems it's not working after a re-deploy.
Maybe it's not the right way.
Thanks for you'r help

It will be fixed in the next major/minor (idk) release of AFFiNE.

Oh okay, thanks.
Sorry, new to github :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Notion import, images not here​
3 participants