Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edgeless): add paragraph block when clicking at empty note block #6457

Conversation

donteatfriedrice
Copy link
Member

To close #6455

Screen.Recording.2024-03-12.at.11.45.56.mov

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 8:38am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2024 8:38am

@donteatfriedrice donteatfriedrice changed the title fix(edgeless): add paragraph block when note is empty fix(edgeless): add paragraph block when clicking at empty note block Mar 12, 2024
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but this seems to be a good edge case to cover test!

@doodlewind doodlewind added the test needed Should provide test cases altogether label Mar 12, 2024
@doodlewind doodlewind enabled auto-merge (squash) March 12, 2024 08:36
@doodlewind doodlewind merged commit d77657a into toeverything:master Mar 12, 2024
19 checks passed
@donteatfriedrice donteatfriedrice deleted the fix/cannot-add-block-on-empty-note branch March 12, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test needed Should provide test cases altogether
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Can't add block when last block is removed from note
3 participants