fix(edgeless): optimize ai panel user experience #6810

fundon · 2024-04-18T09:30:24Z

Closes: AFF-902,AFF-901,AFF-908

vercel · 2024-04-18T09:30:25Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
blocksuite	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 23, 2024 1:42am

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
blocksuite-docs	⬜️ Ignored (Inspect)	Visit Preview		Apr 23, 2024 1:42am

graphite-app · 2024-04-18T09:30:28Z

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

fundon · 2024-04-18T09:30:38Z

fix(edgeless): optimize ai panel user experience #6810 👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite

packages/blocks/src/root-block/edgeless/components/toolbar/edgeless-toolbar.ts

doouding · 2024-04-22T12:49:07Z

By the way, changing the issue ID in the description to the links would be better because others can go to that link directly :)

…he right-click selection

CatsJuice · 2024-05-26T02:44:26Z

packages/blocks/src/root-block/edgeless/components/toolbar/shape/shape-tool-button.ts

@@ -75,10 +75,7 @@ export class EdgelessShapeToolButton extends EdgelessToolButton<
    }

    .container-clip {
-      padding: 10000px 10000px 0;


Led to some unexpected effects #7139

A very large layer will be created here.

Yes, that's expected, to achieve the effect of overflow: clip only on the bottom edge. Is there any performance issue or other problem with this approach?

The layer is always there.

You can consider trying canvas overlayer, or create a separate element outside(fixed/absolute).

Yes, that's expected, to achieve the effect of overflow: clip only on the bottom edge

clip does not work on padding

vercel bot deployed to Preview – blocksuite April 18, 2024 09:46 View deployment

fundon force-pushed the 04_18_optimize-ai-panel branch from f779411 to 3d2ed64 Compare April 18, 2024 11:40

fundon changed the title ~~fix(blocks): optimize ai panel~~ fix(blocks): optimize user experience with ai panel Apr 18, 2024

vercel bot had a problem deploying to Preview – blocksuite April 18, 2024 11:44 Failure

fundon force-pushed the 04_18_optimize-ai-panel branch from 3d2ed64 to 7cdfd9f Compare April 18, 2024 11:56

vercel bot deployed to Preview – blocksuite April 18, 2024 12:08 View deployment

vercel bot had a problem deploying to Preview – blocksuite April 18, 2024 13:48 Failure

fundon changed the title ~~fix(blocks): optimize user experience with ai panel~~ fix(blocks): optimize ai panel user experience Apr 19, 2024

fundon force-pushed the 04_18_optimize-ai-panel branch from 420b3ef to 83cd881 Compare April 22, 2024 02:04

vercel bot had a problem deploying to Preview – blocksuite April 22, 2024 02:09 Failure

fundon force-pushed the 04_18_optimize-ai-panel branch from 83cd881 to adeb8b1 Compare April 22, 2024 08:20

vercel bot deployed to Preview – blocksuite April 22, 2024 08:26 View deployment

fundon force-pushed the 04_18_optimize-ai-panel branch from adeb8b1 to 6396bd8 Compare April 22, 2024 08:50

vercel bot deployed to Preview – blocksuite April 22, 2024 08:56 View deployment

fundon force-pushed the 04_18_optimize-ai-panel branch from 6396bd8 to 8330620 Compare April 22, 2024 09:35

vercel bot had a problem deploying to Preview – blocksuite April 22, 2024 09:36 Failure

fundon force-pushed the 04_18_optimize-ai-panel branch from 8330620 to d1cbfe7 Compare April 22, 2024 09:58

vercel bot had a problem deploying to Preview – blocksuite April 22, 2024 09:59 Failure

vercel bot had a problem deploying to Preview – blocksuite April 22, 2024 11:21 Failure

vercel bot had a problem deploying to Preview – blocksuite April 22, 2024 11:57 Failure

fundon force-pushed the 04_18_optimize-ai-panel branch from 23fc9c7 to 37b9743 Compare April 22, 2024 12:05

vercel bot deployed to Preview – blocksuite April 22, 2024 12:09 View deployment

fundon force-pushed the 04_18_optimize-ai-panel branch from 37b9743 to 1df1ad0 Compare April 22, 2024 12:09

fundon marked this pull request as ready for review April 22, 2024 12:10

fundon requested review from doouding, Flrande and doodlewind April 22, 2024 12:13

vercel bot deployed to Preview – blocksuite April 22, 2024 12:16 View deployment

vercel bot deployed to Preview – blocksuite April 22, 2024 12:26 View deployment

fundon force-pushed the 04_18_optimize-ai-panel branch from 30f2e2d to b1ce879 Compare April 22, 2024 12:32

vercel bot deployed to Preview – blocksuite April 22, 2024 12:35 View deployment

doouding requested changes Apr 22, 2024

View reviewed changes

packages/blocks/src/root-block/edgeless/components/toolbar/edgeless-toolbar.ts Outdated Show resolved Hide resolved

fundon added 8 commits April 23, 2024 09:34

fix(blocks): optimize ai panel

adf2966

fix: stop propagation

bd69c9c

fix: set max height for ai panel answer

466ad68

fix: click ask ai to enter ai mode, consistent with the behavior of t…

3cf3fdc

…he right-click selection

fix: shortcuts are not allowed to switch modes when ai is processing

4c0e097

fix: should switch to default mode when ai panel is discarded

72c6e77

fix: should return when signal is aborted

e23af04

fix: circular dependency

3bf12a2

fundon force-pushed the 04_18_optimize-ai-panel branch 2 times, most recently from 82eb599 to 3277ad8 Compare April 23, 2024 01:37

vercel bot had a problem deploying to Preview – blocksuite April 23, 2024 01:38 Failure

fix: add toolbarLocked slot

02a9e14

fundon force-pushed the 04_18_optimize-ai-panel branch from 3277ad8 to 02a9e14 Compare April 23, 2024 01:39

vercel bot deployed to Preview – blocksuite April 23, 2024 01:42 View deployment

fundon requested a review from doouding April 23, 2024 01:46

doouding approved these changes Apr 23, 2024

View reviewed changes

doouding changed the title ~~fix(blocks): optimize ai panel user experience~~ fix(edgeless): optimize ai panel user experience Apr 23, 2024

doouding merged commit cdd4b4a into master Apr 23, 2024
20 checks passed

doouding deleted the 04_18_optimize-ai-panel branch April 23, 2024 02:15

CatsJuice mentioned this pull request May 26, 2024

Dragging shape in edgeless toolbar will be clipped #7139

Open

CatsJuice reviewed May 26, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(edgeless): optimize ai panel user experience #6810

fix(edgeless): optimize ai panel user experience #6810

fundon commented Apr 18, 2024 •

edited

vercel bot commented Apr 18, 2024 •

edited

graphite-app bot commented Apr 18, 2024

fundon commented Apr 18, 2024

doouding commented Apr 22, 2024 •

edited

CatsJuice May 26, 2024 •

edited

fundon May 26, 2024

CatsJuice May 26, 2024

fundon May 26, 2024 •

edited

fundon May 26, 2024

fundon May 26, 2024

fix(edgeless): optimize ai panel user experience #6810

fix(edgeless): optimize ai panel user experience #6810

Conversation

fundon commented Apr 18, 2024 • edited

vercel bot commented Apr 18, 2024 • edited

graphite-app bot commented Apr 18, 2024

Your org has enabled the Graphite merge queue for merging into master

fundon commented Apr 18, 2024

doouding commented Apr 22, 2024 • edited

CatsJuice May 26, 2024 • edited

Choose a reason for hiding this comment

fundon May 26, 2024

Choose a reason for hiding this comment

CatsJuice May 26, 2024

Choose a reason for hiding this comment

fundon May 26, 2024 • edited

Choose a reason for hiding this comment

fundon May 26, 2024

Choose a reason for hiding this comment

fundon May 26, 2024

Choose a reason for hiding this comment

fundon commented Apr 18, 2024 •

edited

vercel bot commented Apr 18, 2024 •

edited

doouding commented Apr 22, 2024 •

edited

CatsJuice May 26, 2024 •

edited

fundon May 26, 2024 •

edited