Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edgeless): shape text cannot be edited #6957

Merged

Conversation

doouding
Copy link
Member

@doouding doouding commented May 6, 2024

Change

  • Remove redundant pierce property

Copy link

graphite-app bot commented May 6, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 8:16am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 8:16am

Copy link
Member Author

doouding commented May 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @doouding and the rest of your teammates on Graphite Graphite

Copy link
Member Author

@doouding doouding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should allow to pierce the shape when shape has text

Copy link

graphite-app bot commented May 6, 2024

Merge activity

### Change
- Remove redundant `pierce` property
@doouding doouding force-pushed the 05-06-fix_edgeless_shape_text_cannot_be_edited branch from 9b65d3a to 2182803 Compare May 6, 2024 08:10
@graphite-app graphite-app bot merged commit 2182803 into master May 6, 2024
19 checks passed
@graphite-app graphite-app bot deleted the 05-06-fix_edgeless_shape_text_cannot_be_edited branch May 6, 2024 08:18
shvixxl pushed a commit to shvixxl/blocksuite that referenced this pull request May 6, 2024
### Change
- Remove redundant `pierce` property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants