Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(blocks): improve canvas rendering when resizing the window #7237

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Jun 7, 2024

What's Changed!

  • Specifying the actual size gives better results and more consistent behavior across browsers.
  • Make sure the main canvas and the offscreen canvas or layer canvas are the same size.
  • It is not recommended to set width and height to 100%.

Related to #7205

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 4:38am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Jun 7, 2024 4:38am

Copy link

graphite-app bot commented Jun 7, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fundon commented Jun 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Jun 7, 2024

Merge activity

  • Jun 7, 12:26 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 7, 12:36 AM EDT: Saul-Mirone added this pull request to the Graphite merge queue.
  • Jun 7, 12:46 AM EDT: Saul-Mirone merged this pull request with the Graphite merge queue.

### What's Changed!

* Specifying the actual size gives better results and more consistent behavior across browsers.
* Make sure the main canvas and the offscreen canvas or layer canvas are the same size.
* It is not recommended to set width and height to 100%.

Related to #7205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants