Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(blocks): refine format bar #7520

Merged
merged 1 commit into from
Jul 10, 2024
Merged

chore(blocks): refine format bar #7520

merged 1 commit into from
Jul 10, 2024
+156 −168

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Jul 9, 2024 •
edited
Loading

Closes: BS-741

Screenshot 2024-07-09 at 10 44 53 Screenshot 2024-07-09 at 10 45 10 Screenshot 2024-07-09 at 15 44 56

@vercel Vercel
Copy link

vercel bot commented Jul 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 5:21pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 5:21pm

@fundon fundon mentioned this pull request Jul 9, 2024
Merged
@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 9, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

This was referenced Jul 9, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@fundon Graphite App
Copy link
Contributor Author

fundon commented Jul 9, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

@fundon fundon mentioned this pull request Jul 9, 2024
Merged
@fundon fundon marked this pull request as ready for review July 9, 2024 03:14
@fundon fundon force-pushed the 07_07-refine-code-block-toolbar branch from 8eb1ffc to 36941b9 Compare July 9, 2024 03:38
@fundon fundon force-pushed the 07_07-refine-code-block-toolbar branch from 2594b6f to b117987 Compare July 10, 2024 03:36
@fundon fundon force-pushed the 07_07-refine-code-block-toolbar branch from b117987 to df2386e Compare July 10, 2024 04:46
@fundon fundon force-pushed the 07_07-refine-code-block-toolbar branch from df2386e to 0816073 Compare July 10, 2024 05:05
@fundon fundon force-pushed the 07_07-refine-code-block-toolbar branch from 0816073 to fb0264e Compare July 10, 2024 06:52
@fundon fundon force-pushed the 07_07-refine-code-block-toolbar branch from fb0264e to 3780696 Compare July 10, 2024 08:03
@Saul-Mirone Saul-Mirone force-pushed the 07_07-refine-code-block-toolbar branch from 3780696 to 2025310 Compare July 10, 2024 12:05
@Saul-Mirone Saul-Mirone changed the base branch from 07_07-refine-code-block-toolbar to master July 10, 2024 13:04
@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 10, 2024 •
edited
Loading

Merge activity

  • Jul 10, 12:21 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 10, 12:21 PM EDT: Saul-Mirone added this pull request to the Graphite merge queue.
  • Jul 10, 12:30 PM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Playground E2E test (1)').
  • Jul 10, 1:19 PM EDT: Saul-Mirone added this pull request to the Graphite merge queue.
  • Jul 10, 1:29 PM EDT: Saul-Mirone merged this pull request with the Graphite merge queue.

Saul-Mirone pushed a commit that referenced this pull request Jul 10, 2024
@fundon
chore(blocks): refine format bar (#7520)
6f55772 
Closes: [BS-741](https://linear.app/affine-design/issue/BS-741/format-bar)

<img width="504" alt="Screenshot 2024-07-09 at 10 44 53" src="https://github.com/toeverything/blocksuite/assets/27926/cb861d6b-157a-4cf0-b334-998081054b87">
<img width="533" alt="Screenshot 2024-07-09 at 10 45 10" src="https://github.com/toeverything/blocksuite/assets/27926/2315cbfe-8a51-47b8-9d64-6de896dc82ff">
<img width="592" alt="Screenshot 2024-07-09 at 15 44 56" src="https://github.com/toeverything/blocksuite/assets/27926/384bfd07-c9db-4fdb-9cee-4efc69a62fc2">
@graphite-app graphite-app bot removed the merge label Jul 10, 2024
@graphite-app graphite-app bot merged commit edf8101 into master Jul 10, 2024
19 checks passed
@graphite-app graphite-app bot deleted the 07_07-refine-format-bar branch July 10, 2024 17:29
@fundon fundon mentioned this pull request Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saul-Mirone Saul-Mirone Saul-Mirone approved these changes

@fourdim fourdim fourdim approved these changes

@Svaney-ssman Svaney-ssman Awaiting requested review from Svaney-ssman

Assignees
No one assigned
Labels
None yet
Projects
BlockSuite Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fundon @Svaney-ssman @Saul-Mirone @fourdim