Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide instances of loggable for java.time data classes #315

Closed
mehakun opened this issue Jun 15, 2020 · 6 comments
Closed

Provide instances of loggable for java.time data classes #315

mehakun opened this issue Jun 15, 2020 · 6 comments

Comments

@mehakun
Copy link
Contributor

mehakun commented Jun 15, 2020

It would be nice to have instances of those classes.
Maybe new API for formatting dates could be born from this issue :)

@catostrophe
Copy link
Member

They've already been added. But what I don't like is the default formatter.

@mehakun
Copy link
Contributor Author

mehakun commented Jun 16, 2020

Not all of them though :)
For example, there is an open PR: #316
And wouldn't it be easier to add all classes instead of one by one?

@pomadchin
Copy link
Contributor

@Odomontois
Copy link
Member

Can we close this now? @mehakun

@Odomontois
Copy link
Member

We can open new issue regarding format, and maybe refactoring some qualities to the common typeclass such as TimeData

@mehakun
Copy link
Contributor Author

mehakun commented Aug 20, 2020

@Odomontois I it can be closed, currently discussed problem is kinda unrelated to the issue, I agree.

@mehakun mehakun closed this as completed Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants