-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide instances of loggable for java.time data classes #315
Comments
They've already been added. But what I don't like is the default formatter. |
Not all of them though :) |
There is already https://github.com/TinkoffCreditSystems/tofu/blob/ce1171f8bc9d18fa5a2beb6f2a2ee9c99b8349d7/core/src/main/scala/tofu/common/time.scala#L80-L90 Mb we can consolidate |
Can we close this now? @mehakun |
We can open new issue regarding format, and maybe refactoring some qualities to the common typeclass such as TimeData |
@Odomontois I it can be closed, currently discussed problem is kinda unrelated to the issue, I agree. |
It would be nice to have instances of those classes.
Maybe new API for formatting dates could be born from this issue :)
The text was updated successfully, but these errors were encountered: