Kernelize Start\Fire #682
Merged
Kernelize Start\Fire #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Odomontois
requested review from
catostrophe,
danslapman,
oskin1 and
Z1kkurat
as code owners
FunFunFine
reviewed
Jul 1, 2021
| } | ||
|
|
||
| object Fire extends EffectComp[Fire] { | ||
| final implicit def byCarrier[F[_], Fib[_]](implicit |
There was a problem hiding this comment.
I think it's better to note somehow that it's just for scala 2.12
There was a problem hiding this comment.
As in #681 this carrier allows Fib to be inferred within the macro, just like shapeless whitebox macros do the typelevel calculations we can depend on types that can be unknown if the needed module isn't in the classpath
FunFunFine
reviewed
Jul 1, 2021
FunFunFine
previously approved these changes
Jul 1, 2021
vilunov
reviewed
Jul 1, 2021
catostrophe
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using basically the same approach as in #681, while parameterizing Start over Fiber into new type class Fibers