Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add support for atmos #129

Merged
merged 6 commits into from
May 13, 2024

Conversation

astephanh
Copy link
Contributor

@astephanh astephanh commented May 12, 2024

This is a quick and dirty copy&paste addition to support atmos from cloudposse. Maybe someone with real Go experience can extend and merge this feature.

tested features:

  • list remote versions
  • download new version
  • use version in .atmos-version
  • use version in ATMOS_VERSION env var

missing:

  • not completely tested
  • no test functions

@dvaumoron
Copy link
Contributor

Seem interesting, I will review your PR soon

@dvaumoron
Copy link
Contributor

You need to rebase to add sign-off

@dvaumoron
Copy link
Contributor

are .atmosswitchrc or .atmosswitch.toml useful ? There equivalent are supported in order to be compatible with previously existing tools.

@dvaumoron dvaumoron self-requested a review May 13, 2024 16:38
@astephanh
Copy link
Contributor Author

are .atmosswitchrc or .atmosswitch.toml useful ? There equivalent are supported in order to be compatible with previously existing tools.

i don't know. probably not. i've just copied it over from terragrunt

@astephanh
Copy link
Contributor Author

You need to rebase to add sign-off

what do i need to do?

@dvaumoron
Copy link
Contributor

See https://github.com/tofuutils/tenv/pull/129/checks?check_run_id=24913994283

(oops, it seems I forgot one too)

Something like :

git rebase -i HEAD~6

Then you will have a vi editor with :

pick 56acce8 feat: Add initial support for atmos
pick c1901aa fix: removing not used parser functions for hcl and json
pick cc1ba51 Update tenv.go
pick e8072d4 remove not used atmos file support]
pick c48fb6b remove unused atmos values
pick 635cf69 enable check sha256

# Rebase 56acce8..635cf69 onto 56acce8
#
# Commands:
#  p, pick = use commit
#  r, reword = use commit, but edit the commit message
#  e, edit = use commit, but stop for amending
#  s, squash = use commit, but meld into previous commit
#  f, fixup = like "squash", but discard this commit's log message
#  x, exec = run command (the rest of the line) using shell
#
# These lines can be re-ordered; they are executed from top to bottom.
#
# If you remove a line here THAT COMMIT WILL BE LOST.
#
# However, if you remove everything, the rebase will be aborted.
#
# Note that empty commits are commented out

You have to rewrite it to get

reword 56acce8 feat: Add initial support for atmos
reword c1901aa fix: removing not used parser functions for hcl and json
pick cc1ba51 Update tenv.go
pick e8072d4 remove not used atmos file support]
pick c48fb6b remove unused atmos values
reword 635cf69 enable check sha256

# Rebase 56acce8..635cf69 onto 56acce8
#
# Commands:
#  p, pick = use commit
#  r, reword = use commit, but edit the commit message
#  e, edit = use commit, but stop for amending
#  s, squash = use commit, but meld into previous commit
#  f, fixup = like "squash", but discard this commit's log message
#  x, exec = run command (the rest of the line) using shell
#
# These lines can be re-ordered; they are executed from top to bottom.
#
# If you remove a line here THAT COMMIT WILL BE LOST.
#
# However, if you remove everything, the rebase will be aborted.
#
# Note that empty commits are commented out

Then you will have one by one the commit comment to rewrite in vi editor, where you should add Signed-off-by: Stephan Helas <your_github_account@email.com> (or Signed-off-by: Denis Vaumoron <dvaumoron@gmail.com> for the last)

To finish git push --force-with-lease (you need a github token with "repo" and "write:packages" right, see doc)

astephanh and others added 6 commits May 13, 2024 21:03
Signed-off-by: Stephan Helas <stephan.helas@gmail.com>
Signed-off-by: Stephan Helas <stephan.helas@gmail.com>
Signed-off-by: Denis Vaumoron <dvaumoron@gmail.com>
Signed-off-by: Denis Vaumoron <dvaumoron@gmail.com>
Signed-off-by: Denis Vaumoron <dvaumoron@gmail.com>
Signed-off-by: Denis Vaumoron <dvaumoron@gmail.com>
@astephanh
Copy link
Contributor Author

ok, did the signing-off thingy :)

@dvaumoron dvaumoron merged commit 3a6337c into tofuutils:main May 13, 2024
4 checks passed
@astephanh astephanh deleted the feature/cloudposse-atmos branch May 14, 2024 05:42
@dvaumoron dvaumoron removed their request for review May 16, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants