-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link EA Profiles #1
Comments
Currently you can set a "Personal Link" in your preferences, but I couldn't find out whether that's displayed anywhere. Is it? |
That whole sidebar is not displayed in the EA forum. You can find the code for it under templates/profilebar.html; the specific lines generating the website link are:
Edit: the html that I tried to copy and paste has gotten processed by Github. Meh. |
Cool, do you want to try adapting that to start with Alex? I'd strongly On 1 July 2015 at 21:36, arichard4 notifications@github.com wrote:
|
Sorry for the schizophrenic assigned/unassigned messages. This is a good task for multiple people to work on so it's still great to have your help @patbl ! |
Is the idea that this would be in addition to the personal link, or instead of it? The personal link isn't currently being displayed anywhere. |
Instead of, at least for now. |
(Given that the personal link isn't chosen it seems easiest to at least start by taking advantage of it's already being set up to write to the database, etc. - @peterhurford and I couldn't figure out how to do that when we tried e.g. 34bc808 .) |
Merge pull request #16 from arichard4/master
Problem: most of the places we would be putting the link to the profile seem to cache their messages, meaning that updates to the profile won't get through to the users for some time. Is this significant/a problem? |
It's not a significant problem - let's just live with it at least in v1. On 6 July 2015 at 02:38, arichard4 notifications@github.com wrote:
|
OK, I've pushed to the branch link-to-profile. |
I made a PR and merged it into our master branch. #19 I'll merge from the branch to Trike soon, but I want to give them a chance to handle their current PRs first. |
Actually, can you hang on and not merge? The top contributors is showing the head icon twice, beside the username and the profile link; I hadn't noticed this before because it didn't update immediately. |
OK, I've fixed that. Would somebody else mind taking a look at this de novo, though? It seems like my system is taking a while to update when I see in my browser when I make a change in a source file. (The user options should only accept a link to an ea profile, i.e. effectivealtruismhub.com/user/something, and then there should be a link to their profile beside their username on posts, comments and meetups immediately, and the sidebar comments and top monthly contributors once the system refreshes.) |
👍 I can QA this sometime soon. |
❤️ to both |
I've found that too.
I just tested your changes and I see all this, except I can't add meetups and can't see top monthly contributors:
|
Could someone explain what these links to the profiles are to look like? I don't have a monopoly over changes to the forum but it would be good to be told that people are actively starting to integrate the site with another site. Obviously it's the first issue and has been here for a month but would be good to tag me for this sort of thing. |
Are we bringing back LW's old right profile sidebar? The higher priority thing from there is the button that you use to message people. Bringing back the profile sidebar in its entirety has the downside of making the ux more complex. |
|
Thanks for the reply. Also thanks everyone for all the new awesome features and important fixes implemented since the hackathon! The button for messaging people sounds ideal! As for the links to profiles, I can see the instinct to try to bring ea apps together. But might it be excessive to display the link to the profiles next to the name everywhere? When you say it appears next to posts, does it also appear on the frontpage? The more minimal alternative would be to just place a link from the user page e.g. http://effective-altruism.com/user/TopherHallquist/? There's some disadvantages to EA profile integration in general, in that the site has a new dependency (albeit one that might be easily removed). But also the user experience might be worse if the link is featured everywhere: it could be a bit jarring to be moved to a separate site with different design and interface. Also, if you visit the EA Profiles and want to see that individual's writing, presumably the profiles database does not know which forum user page that individual is connected to, correct? Thoughts? |
I think it makes sense to integrate in other EA services, assuming people like them, since it's the only way they'll get used. I remember talking to you about this a few months ago and you seemed onboard with this at that point, though maybe only as a general principle and of course it's easy to forget. But I don't think there are any sizable risks to "introducing dependencies", generally speaking. The one concern I agree with is avoiding making the layout ugly. A link on the user page might as well not exist, I feel, since I imagine so few people look there. So I'd want it to be more visible than that. But I'm not sure what layout we're going for here (maybe @arichard4 can provide screenshots?). I agree it would get very ugly for "[click here for profile]" to be next to all the names (the most extreme case), but maybe we could use the cute person icon? Additionally, maybe we could put something like "Read more about Topher Hallquist at his EA profile" at the end of Topher's posts (and so on for all users)? I think a lot of us are keen to see this integration and other integrations like it. What do you think? |
@tog22 , comments? |
@arichard4 , that basic functionality looks good to me! I don't think there's any more you need to do on it just yet, we can sort out that functionality and then move onto any tweaks, aesthetic or otherwise. Thanks for all your hard work on this, I know a lot of people who've requested and will appreciate it 😃 @RyanCarey , I'm sorry you felt out of the loop! It's easy to forget/get confused about these things, but I've just looked over this and earlier conversations with you, and we'd discussed cross-linking right when you suggested pursuing Hub/Forum synergies when the forum launched, and had been discussing the feature for a while afterwards. You said a few times that you were happy with our submitting our own code for it to Trike (but just couldn't yourself get them to do new features, when they didn't even have capacity to deal with the bug backlog). So that's partly what we've been going on. Re your question about EA Profile -> EA Forum links, you and I discussed that when we first agreed to cross-link, and I added them, including ones for authors that you sent, though we both decided to make them opt-in - like the EA Forum -> EA Profile links added in these commits. (It's worth bearing in mind that people will be choosing to show a link to their profile when they comment or post, to let readers find out more about them and who they are, so it's reasonable and valuable to give them this choice.) Leaving aside the aesthetic or other details for now, I hope we can get some sort of consensus on this? 😃 |
Thanks for the clarifications, and especially the screenshot, which makes it clear what exactly we're talking about. I'm not sure this is positive value as is. In general, I've been supportive of the forum and profiles (or any other service) connecting to each other, if it's of overall benefit. My reservation is that putting '(Profile)' next to every name puts it in too many locations:
What's tricky is that the external link gives a sudden change of UI with a link-back not always present. Also it only works for users who sign up to both sites and manually enter their username in menus of both sites. Re dependencies, what I was saying is that it's non-ideal that the links all break if EA Profiles goes down or its URLs change. If you guys are convinced that the feature is important, then I think it would be good to address 1-3. I get that this would be harder than simply adding the profile link to the name wherever this appears. What do you guys think? |
@tog22, I back in September, I had spoke in some generalities:
Am I confused? |
Yep, I was referring primarily to other conversations where we discussed it more specifically in the ways I 😄 I'll try working out ways we can address 1-3 later. |
Another thing: Have some people already entered links to personal websites already? If so, then when we put up a profiles link using the extant pref_url, their profile will then link to their personal website. |
Given they're not displayed anywhere we wouldn't lose anything and can't see, but before displaying them (when you check e.g. |
Smaller, prettier & out of sidebar - nice. You guys can maintain e.g. if You all seem keen so feel free to take it forward. :) This look better? (I'm still waiting on the Top Monthly Contributors to [image: 2015-07-14-065939_1366x768_scrot] — |
I'm assuming that I should push to master, since it already has the old verison of the profile links in it... If not, let me know. New profile links, per issue #1
Yep, I hereby solemnly promise ⭐
That's great, I'm really glad we managed to achieve consensus! 👬 @peterhurford , I've tested this throroughly and done almost all the work to get ready for a pull request in https://github.com/tog22/eaforum/commits/issue-1-for-pr pending @arichard4 answering some questions on a Facebook message thread. |
The user should be able to go to their account settings and set their EA Profile link (similar to how they can already include a personal link). This should then prominently appear on their account page (i.e., when you click on their name).
The text was updated successfully, but these errors were encountered: