This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
Attempt at fixing the crash in EventQueue destructor (lib) #4050
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could fix the crash.
The rationale behind this is checking if the thread is valid. If it is, we need to determine if the destructor was called from the main thread or not.
I definitely don't recommend calling it from the EventQueue thread though, using the main thread to destroy everything seems to be the right call.