Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggl Button doesn't pull Github issue number properly on Project board #1343

Closed
ricotheque opened this issue Mar 14, 2019 · 1 comment
Closed

Toggl Button doesn't pull Github issue number properly on Project board #1343

ricotheque opened this issue Mar 14, 2019 · 1 comment
Assignees
@tcrammond
Labels
bug released

Comments

@ricotheque
Copy link

  • OS version: macOS Mojave 10.14.3
  • Browser version: 72.0.3626.121 (Official Build) (64-bit)
  • Extension version: 1.22.2

Relevant integration (if any):

github.com

🐛 Describe the bug

When starting the timer while viewing an issue on a Github Project board, the new Time Entry's description has the right issue title — but the wrong number.

Expected behaviour

When starting the timer while viewing an issue on a Github Project board, the new Time Entry's description should have the right issue title and number.

Steps to reproduce

Steps to reproduce the behaviour:

  1. Open a Project board on Github
  2. Click the title of an issue on the upper-leftmost of the board
  3. On the side pane that appears, click Start Timer
  4. See a new Time Entry be generated, with the correct issue title and number
  5. Repeat steps 1 - 3, but with the next issue on the board
  6. See a new Time Entry be generated, with the correct issue title but the wrong number

Other details or context

case
@ricotheque ricotheque added the bug label Mar 14, 2019
@tcrammond tcrammond self-assigned this Mar 20, 2019
tcrammond added a commit that referenced this issue Mar 20, 2019
@tcrammond
fix(github): Find correct issue number in GitHub project board
48fd2ed 
Closes #1343.
tcrammond added a commit that referenced this issue Mar 20, 2019
@tcrammond
fix(github): Find correct issue number in GitHub project board
7412873 
Closes #1343.
tcrammond added a commit that referenced this issue Apr 23, 2019
@tcrammond
fix(github): Find correct issue number in GitHub project board
98fd47c 
Closes #1343.
toggl-button-bot added a commit that referenced this issue Apr 23, 2019
@toggl-button-bot
chore(release): 1.30.4 [skip ci]
c9d6116 
## [1.30.4](1.30.3...1.30.4) (2019-04-23)

### Bug Fixes

* **github:** Find correct issue number in GitHub project board ([d3cb4d5](d3cb4d5)), closes [#1343](#1343)
* **google-mail:** Standardize button style ([69d9219](69d9219))
* **trello:** Fix card button clicks not starting the timer ([878c42a](878c42a)), closes [#1299](#1299)
* **trello:** Stop toggl button overlapping trello list menus ([0dcc23a](0dcc23a)), closes [#1299](#1299)
* **zendesk:** Improve button layout and style ([240510f](240510f))
@toggl-button-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 1.30.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcrammond tcrammond

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ricotheque @tcrammond @toggl-button-bot