Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings are not saved #1353

Closed
FeBe95 opened this issue Mar 20, 2019 · 4 comments 路 Fixed by #1355
Closed

Settings are not saved #1353

FeBe95 opened this issue Mar 20, 2019 · 4 comments 路 Fixed by #1355
Assignees
@tcrammond
Labels
bug released

Comments

@FeBe95
Copy link

FeBe95 commented Mar 20, 2019

  • OS version: Windows 10 (1809)
  • Browser version: Firefox 66.0
  • Extension version: 1.23.3

馃悰 Describe the bug

Settings are reset every time the browser is restarted

Expected behaviour

Settings like idle detection are persistent

Steps to reproduce

  • login in the extension popup
  • open the new standalone settings page by clicking the settings icon or via the add-ons page
  • change something
  • optionally wait some time, refresh the page, do some stoff
  • quit Firefox
  • re-open Firefox
  • open settings page again
  • many settings are restored to its default values

Other details or context

  • happening since the last update, works fine in 1.22.2 (previous version, installed from mozilla.org)
@FeBe95 FeBe95 added the bug label Mar 20, 2019
@nicktoggl
Copy link

nicktoggl commented Mar 21, 2019 •
edited
Loading

ref - conversations/21290798500

tcrammond added a commit that referenced this issue Mar 21, 2019
@tcrammond
fix(settings): Fix some settings being overwritten with default values
b5f780b 
Closes #1353.
@tcrammond tcrammond self-assigned this Mar 21, 2019
@tcrammond
Copy link
Contributor

Thanks for reporting this. A fix is in the works.

@tcrammond tcrammond mentioned this issue Mar 21, 2019
Merged
tcrammond added a commit that referenced this issue Mar 21, 2019
@tcrammond
fix(settings): Fix some settings being overwritten with default values
b5c94bf 
Closes #1353.
toggl-button-bot added a commit that referenced this issue Mar 21, 2019
@toggl-button-bot
chore(release): 1.23.4 [skip ci]
9173262 
## [1.23.4](1.23.3...1.23.4) (2019-03-21)

### Bug Fixes

* **settings:** Fix some settings being overwritten with default values ([b5c94bf](b5c94bf)), closes [#1353](#1353)
* Fix errors on workdayEnd when $curEntry is null ([8951ef4](8951ef4))
@toggl-button-bot
Copy link
Collaborator

馃帀 This issue has been resolved in version 1.23.4 馃帀

The release is available on GitHub release

Your semantic-release bot 馃摝馃殌

@tcrammond
Copy link
Contributor

1.23.4 has been published and should arrive in your browser in the next few hours. Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcrammond tcrammond

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix some settings being overwritten with default values on load toggl/track-extension
4 participants
@tcrammond @FeBe95 @nicktoggl @toggl-button-bot