Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Shortuct (previously Clubhouse) #2006

Merged
merged 1 commit into from Nov 22, 2021

Conversation

aidankinzett
Copy link
Contributor

@aidankinzett aidankinzett commented Sep 11, 2021

Please remember the Contributing Guidelines ❤️

🌟 What does this PR do?

Clubhouse have changed their name to Shortcut, and their domain to shortcut.com. This PR uses the old integration to add support for this new domain, skins the button to better match the website theme, and adds the ability to pulls the story id from the card.

Screenshot

🐛 Recommendations for testing

I have tested this on both Firefox and Chrome. The button is accessible on a card in Shortcut.

📝 Links to relevant issues or information

Clubhouse's name is now Shortcut

@aidankinzett aidankinzett changed the title Add support for Shortuct (previously Clubhouse) feat: Add support for Shortuct (previously Clubhouse) Sep 11, 2021
@aidankinzett aidankinzett changed the title feat: Add support for Shortuct (previously Clubhouse) feat: Add support for Shortuct (previously Clubhouse), fixes #2010 Oct 4, 2021
@aidankinzett aidankinzett changed the title feat: Add support for Shortuct (previously Clubhouse), fixes #2010 feat: Add support for Shortuct (previously Clubhouse) Oct 4, 2021
@aidankinzett
Copy link
Contributor Author

Can I request this for review somehow? Our team used to use the clubhouse integration, but I have to pass around a dev build of the extension to be able to use it with shortcut and reload it every time the browser closes

Copy link
Contributor

@nunofmn nunofmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 🚀

@nunofmn nunofmn merged commit 208fe9c into toggl:master Nov 22, 2021
toggl-button-bot added a commit that referenced this pull request Nov 22, 2021
# [1.72.0](1.71.0...1.72.0) (2021-11-22)

### Features

* Add support for shortuct (previously clubhouse) ([#2006](#2006)) ([208fe9c](208fe9c))
@toggl-button-bot
Copy link
Collaborator

🎉 This PR is included in version 1.72.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@darrenaalfonso
Copy link

darrenaalfonso commented Jan 7, 2022

I don't see the Start Timer button on individual Shortcut story pages?

@MarkBennett
Copy link

I don't see the Start Timer button on individual Shortcut story pages?

Screen Shot 2022-01-07 at 6 37 46 AM

It's showing up for me. Have you enabled the integration in your Toggl extension options in Chrome? I don't believe it's on by default.

Screen Shot 2022-01-07 at 6 38 30 AM

Hope this helps! :)

@darrenaalfonso
Copy link

@MarkBennett - Yup I've got it enabled. I've also tried disabling all other extensions. I've also tried Firefox. Maybe something with the specific Shortcut board I'm using? If anyone needs logs, lmk and I can supply.

@lunikon
Copy link

lunikon commented Jan 13, 2022

I am seeing the same problem as @darrenaalfonso. No Toggl button to be seen anywhere in the Shortcut UI. Enabling/disabling the integration or even the whole plugin does not help. Neither do browser restarts.

@MarkBennett
Copy link

Could there be another extension interferring? I just tried again and it's working for me still. Sorry I can't be more helpful! 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants