New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Shortuct (previously Clubhouse) #2006
Conversation
Can I request this for review somehow? Our team used to use the clubhouse integration, but I have to pass around a dev build of the extension to be able to use it with shortcut and reload it every time the browser closes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍 🚀
# [1.72.0](1.71.0...1.72.0) (2021-11-22) ### Features * Add support for shortuct (previously clubhouse) ([#2006](#2006)) ([208fe9c](208fe9c))
🎉 This PR is included in version 1.72.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
I don't see the |
@MarkBennett - Yup I've got it enabled. I've also tried disabling all other extensions. I've also tried Firefox. Maybe something with the specific Shortcut board I'm using? If anyone needs logs, lmk and I can supply. |
I am seeing the same problem as @darrenaalfonso. No Toggl button to be seen anywhere in the Shortcut UI. Enabling/disabling the integration or even the whole plugin does not help. Neither do browser restarts. |
Could there be another extension interferring? I just tried again and it's working for me still. Sorry I can't be more helpful! 😛 |
Please remember the Contributing Guidelines ❤️
🌟 What does this PR do?
Clubhouse have changed their name to Shortcut, and their domain to
shortcut.com
. This PR uses the old integration to add support for this new domain, skins the button to better match the website theme, and adds the ability to pulls the story id from the card.🐛 Recommendations for testing
I have tested this on both Firefox and Chrome. The button is accessible on a card in Shortcut.
📝 Links to relevant issues or information
Clubhouse's name is now Shortcut