Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Stop Timer Automatically" Feature Not Working #1687

Open
TheSoloJake opened this issue Mar 9, 2020 · 7 comments 路 May be fixed by #1767
Open

"Stop Timer Automatically" Feature Not Working #1687

TheSoloJake opened this issue Mar 9, 2020 · 7 comments 路 May be fixed by #1767
Labels
bug up for grabs PRs that need a new owner to work on it.

Comments

@TheSoloJake
Copy link

  • OS version: macOS 10.15.3
  • Browser version: Chrome Latest Stable
  • Extension version: 1.60.5

馃悰 Describe the bug

When using the "Stop Timer Automatically" feature, the timer will not stop when the browser is closed.

Expected behaviour

When the browser is closed, the timer should automatically stop.

Other details or context

N/A

@TheSoloJake TheSoloJake added the bug label Mar 9, 2020
@dianetoggl
Copy link

Case reference

@tcrammond
Copy link
Contributor

@TheSoloJake Do you have a case reference for this one as well by any chance?

@TheSoloJake
Copy link
Author

TheSoloJake commented Apr 14, 2020

@tcrammond Honestly I did not receive any kind of a ping on this. I don't personally have a case reference at this time. If I remember correctly, I was able to replicate at the time in my copy of Chrome.

I can verify that 1.60.7 does not appear to have this issue.

@dianetoggl
Copy link

馃槵 I still have the issue in 1.60.7

@dianetoggl
Copy link

Hey just following up on this one @tcrammond - I tested in 1.60.9 and the issue is still there 馃槉

@tcrammond
Copy link
Contributor

Hmm, recently closed a duplicate of this here #1735 (comment)

I didn't realise there were more than the single report. let's look into improving this if possible - I think the problem is that the browser sometimes closes down before the extension can finish making requests. Hopefully we can do something about it.

@tcrammond tcrammond self-assigned this Jun 23, 2020
@tcrammond tcrammond linked a pull request Jun 23, 2020 that will close this issue
@tcrammond tcrammond added the up for grabs PRs that need a new owner to work on it. label Jun 29, 2020
@tcrammond tcrammond removed their assignment Jun 29, 2020
@tomelliot
Copy link

Looks like the PR wasn't up to scratch and was rejected. I'll just add my comment here that I've also experienced this issue with the following setup:
image
image

One note: I'm using the profiles in Brave, so I close the profile that has Toggl installed and tracking, but there are still other profiles open.

An additional problem (related/unrelated?) that I noticed at the same time: Several chunks of time that should have been ended when the browser closed got duplicated. So I had several cases where there were 2 blocks of time with the same start and end time, all of which should have ended when I closed the browser but didn't.

Anyone know of any workarounds, aside from just manually stopping and starting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug up for grabs PRs that need a new owner to work on it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants