Repository navigation
#134 Add Spring-Boot integration - #154
Conversation
| <groupId>org.jboss.spec.javax.servlet</groupId> | ||
| <artifactId>jboss-servlet-api_3.0_spec</artifactId> | ||
| <scope>provided</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Do we really need this dependency? Is it will be added to any application that uses this module? Hm... Looks like overkill and dependency to something from org.jboss maybe isn't good IMHO.
Do we need it for javax.servlet.* classes? What dependency Spring Boot uses for that?
There was a problem hiding this comment.
It is provided scope so I don't see the issue. This is how Togglz project depends on servlet spec.
It just assumes javax.servlet.* is available. Only needed to compile project, and actual servlet implementation provided by Boot (or it's appropriate starter).
There was a problem hiding this comment.
I think <optional> dependencies are fine. But I'm curious. Why is there an optional dependency on Hibernate Validator?
Togglz uses the JBoss provided Java EE spec Maven artifacts. Actually it doesn't matter so much which one is used as it is provided scoped.
|
@marceloverdijk Thank you very much for the pull request. I think it is fine. I'll merge it now. Perhaps we get some more people to test as it is now part of the official snapshots. Thanks a lot for your help. 🍻 |
#134 Add Spring-Boot integration
Here is the Spring Boot integration code.
We need to give some special attention to
spring-boot-starter/template.mf:I'm not familiar with this bundlor template.mf format.
I took examples from
spring-coreandspring-securityregarding versions.For the rest I took
"0"as I noticed in other files as well.Does
4.0mean that it should be in4.0.xrange? Spring is already in4.2.xrange so I then wonder if template.mf contents are correct?I will create another PR in the
togglz-siterepo containing the documentation later.