Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More efficient FeatureManagerBuilder #971

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

MarkRx
Copy link
Contributor

@MarkRx MarkRx commented Mar 19, 2023

Fixes #966 by avoiding creating unused defaults

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 72.72% and project coverage change: -0.03 ⚠️

Comparison is base (0e08e5b) 55.84% compared to head (62340c7) 55.81%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #971      +/-   ##
============================================
- Coverage     55.84%   55.81%   -0.03%     
- Complexity      914      917       +3     
============================================
  Files           178      178              
  Lines          4502     4506       +4     
  Branches        592      596       +4     
============================================
+ Hits           2514     2515       +1     
- Misses         1826     1827       +1     
- Partials        162      164       +2     
Impacted Files Coverage Δ
...org/togglz/core/manager/FeatureManagerBuilder.java 75.60% <72.72%> (-5.48%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bennetelli
Copy link
Member

Thank you very much for your PR :)

@bennetelli bennetelli self-requested a review March 23, 2023 09:02
@bennetelli bennetelli merged commit 76ac1a5 into togglz:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FeatureManagerBuilder slow initialization performance
3 participants