-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing RM apis #48
Add missing RM apis #48
Conversation
671aeea
to
a72c72f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff @dimon222!
Just had the one comment regarding headers
.
@kevin-bates i've applied specified corrections and added all the tests I was able to figure out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @dimon222!
@dimon222 - could you please rebase your branch with master? I'll merge your PRs tomorrow - assuming there are no objections. Thanks. |
15de9a4
to
8cfb72e
Compare
8cfb72e
to
4080431
Compare
Thanks @dimon222! |
This PR is to cover missing APIs for RM mentioned in #34 (comment)
Some gaps left still, not sure if it worth merging before filling those.
It's only covering RM, not other components (that might still have some API off)