Allow Cache\File to use an absolute path for the temp directory #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing implementation uses the system-wide temp directory, but it is sometimes useful to inject an absolute path into the constructor, e.g. if the location has been computed elsewhere, or for an application with a self-contained cache directory (most Symfony 2 apps for example).
|
Hi @fazy Travis fails because of this issue https://github.com/trustpilot/developers/issues/27 - we got no new from trustpilot yet :-/ |
|
@fazy any news about this ? :) |
|
The Trustpilot JSON feed will be discontinued https://github.com/trustpilot/developers/issues/27#issuecomment-75207809 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing implementation uses the system-wide temp directory, but it is sometimes useful to inject an absolute path into the constructor, e.g. if the location has been computed elsewhere, or for an application with a self-contained cache directory (most Symfony 2 apps for example).
I needed this for example while working on my current Symfony 2 application - other cache files are in /var/www/myApplication/app/cache/(dev|prod|test), so I didn't really want the TrustPilot one to be in /tmp.
Hope it's ok. :)