Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving towards tiny functions #9

Merged
merged 4 commits into from
Jun 11, 2017
Merged

Moving towards tiny functions #9

merged 4 commits into from
Jun 11, 2017

Conversation

TehShrike
Copy link
Contributor

Left to do:

  • make a basic test for each operation based on the current behavior
  • split all helpers out into their own modules
  • change CJS to ESM (use reify for tests)
  • eliminate or make more efficient the search for a conversion path in convert-to-type.js

@TehShrike
Doesn't work yet!
da34f93 
Eliminated some cyclic dependencies, got rid of everything-injection
@TehShrike
Conversion tests passing again
0f6ab9c
@mpalmr mpalmr changed the base branch from master to refactor June 11, 2017 00:11
@mpalmr mpalmr closed this Jun 11, 2017
@mpalmr mpalmr reopened this Jun 11, 2017
@mpalmr mpalmr merged commit 6e2e65c into graypegg:refactor Jun 11, 2017
@TehShrike TehShrike mentioned this pull request Jun 11, 2017
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TehShrike @mpalmr