Fix image build on buildbot. #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other small improvements: - Run buildbot on every push - Don't use `toit.pkg pkg`. The `pkg` command isn't necessary anymore. - Fetch esp dependencies in separate build step as it has lots of output.
kasperl
reviewed
Jan 19, 2022
| @@ -2,7 +2,6 @@ name: Build | |||
|
|
|||
| on: | |||
| push: | |||
| branches: [main] | |||
| pull_request: | |||
There was a problem hiding this comment.
Didn't you realize that you don't need to keep the pull_request part when all branches are covered elsewhere?
|
Landing to make progress with the release of v0.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other small improvements:
toit.pkg pkg. Thepkgcommand isn't necessary anymore.output.