Add new command, compile, that makes a snapshot #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floitsch
approved these changes
Jun 13, 2022
| "can be run on a Jaguar device as a new program. The snapshot also\n" + | ||
| "contains debug information that can be used by host-side tools.", | ||
| Args: cobra.ExactArgs(1), | ||
| SilenceUsage: true, |
There was a problem hiding this comment.
Maybe add:
Hidden: true,
so that it's not in the help.
| if err != nil { | ||
| return err | ||
| } | ||
| snapshot := filepath.Join(snapshotsCache, device.ID+".snapshot") |
There was a problem hiding this comment.
As discussed, eventually this should become the application ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step will be changing "jag run" so it can take a precompiled snapshot file.
Then adding other utilities that can use the snapshot file.