Watch directories and not files. #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Editors, like VIM, often save files by writing into a temporary file first and then only replacing the original file. If we watch a file we wouldn't get any notifications as we would watch a deleted file. Watching directories is the recommended approach: https://github.com/fsnotify/fsnotify?tab=readme-ov-file#watching-a-file-doesnt-work-well
kasperl
approved these changes
Mar 20, 2024
| for p := range w.paths { | ||
| if _, ok := candidates[p]; !ok { | ||
| w.Mutex.Lock() | ||
| w.watcher.Remove(p) | ||
| delete(w.paths, p) |
There was a problem hiding this comment.
Check that deleting while iterating is okay and add a comment.
There was a problem hiding this comment.
| } | ||
| for d := range w.dirs { | ||
| if _, ok := candidateDirs[d]; !ok { | ||
| delete(w.dirs, d) |
There was a problem hiding this comment.
Check that deleting while iterating is okay and add a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editors, like VIM, often save files by writing into a temporary file first and then only replacing the original file. If we watch a file we wouldn't get any notifications as we would watch a deleted file.
Watching directories is the recommended approach:
https://github.com/fsnotify/fsnotify?tab=readme-ov-file#watching-a-file-doesnt-work-well