Make copying more predictable. #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't make the copy operation dependent on whether the target directory exists or not. Making it dependent has the following drawbacks: 1. the directory could be created outside of our control. 2. It's annoying in programs to test first whether the target exists. 3. There isn't a good way to copy the content of the source to the target if it already exists.
|
Also enabled some tests and fixed them. |
erikcorry
approved these changes
Mar 9, 2024
src/file.toit
Outdated
| if not target-stat: | ||
| mkdir target source-permissions | ||
| if is-windows and source-permissions & SPECIAL-WINDOWS-PERMISSIONS_ != 0: | ||
| // The Windows file attributes are not taking into account when creating a new directory. |
src/file.toit
Outdated
| out-writer := Writer out-stream | ||
| try: | ||
| while data := in-stream.read: | ||
| out-writer.write data | ||
| finally: | ||
| in-stream.close | ||
| out-writer.close | ||
| if is-windows and (source-permissions & SPECIAL-WINDOWS-PERMISSIONS_) != 0: | ||
| // The Windows file attributes are not taking into account when creating a new file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't make the copy operation dependent on whether the target directory exists or not.
Making it dependent has the following drawbacks: