Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't accidentally drop environment argument #77

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Don't accidentally drop environment argument #77

merged 1 commit into from
Apr 3, 2024

Conversation

erikcorry
Copy link
Member

No description provided.

@erikcorry erikcorry requested a review from floitsch April 2, 2024 07:55
floitsch
floitsch approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@floitsch floitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Add test?

@floitsch floitsch merged commit 2588faa into main Apr 3, 2024
6 checks passed
@floitsch floitsch deleted the drop-environment branch April 3, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floitsch floitsch floitsch approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erikcorry @floitsch