Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mark-closed instead of close-X. #137

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Use mark-closed instead of close-X. #137

merged 1 commit into from
Apr 11, 2024

Conversation

floitsch
Copy link
Member

No description provided.

@floitsch floitsch requested a review from kasperl April 10, 2024 10:57
kasperl
kasperl approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@kasperl kasperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@floitsch
Copy link
Member Author

Will wait until 145 is released to commit.

@floitsch floitsch merged commit 614dd0f into main Apr 11, 2024
6 checks passed
@floitsch floitsch deleted the floitsch/mark-closed branch April 11, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperl kasperl kasperl approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@floitsch @kasperl