Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang 13 on macOS mis-compiles third_party/esp-idf/components/mbedtls #130

Closed
kasperl opened this issue Dec 13, 2021 · 3 comments
Closed

Clang 13 on macOS mis-compiles third_party/esp-idf/components/mbedtls #130

kasperl opened this issue Dec 13, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@kasperl
Copy link
Member

kasperl commented Dec 13, 2021

The Toit virtual machine compiled with Clang 13 on macOS, does not have a working TLS implementation. Clang 12.0.5 generates the correct code.

Could be related to Mbed-TLS/mbedtls#5052.
@kasperl kasperl added bug Something isn't working critical This is a critical issue labels Dec 13, 2021
@kasperl
Copy link
Member Author

kasperl commented Dec 13, 2021

At least one problem is here: https://github.com/espressif/mbedtls/blob/6465247f67167518b8813ae2faaf422704e4b1a3/include/mbedtls/bn_mul.h#L258.

This should be fixed like here: Mbed-TLS/mbedtls@d337fbc.

@kasperl kasperl removed the critical This is a critical issue label Dec 14, 2021
@kasperl
Copy link
Member Author

kasperl commented Dec 14, 2021

The GitHub actions we use to build releases now use Clang 12, which makes this less critical.

See 25dc42a.

floitsch added a commit that referenced this issue Jul 21, 2022
@floitsch
Move to newer builder.
8e3f274 
Windows-latest is now Windows-2022.
The fix for mbdetls has been merged. So we don't need an older macos
anymore. See #130.
floitsch added a commit that referenced this issue Jul 21, 2022
@floitsch
Move to newer builder.
654db9f 
Windows-latest is now Windows-2022.
The fix for mbdetls has been merged. So we don't need an older macos
anymore. See #130.
@floitsch floitsch mentioned this issue Jul 21, 2022
Merged
@floitsch
Copy link
Member

Has been fixed by upgrading ESP-IDF.

floitsch added a commit that referenced this issue Jul 28, 2022
@floitsch
Move to newer builder. (#886)
5a10dba 
Windows-latest is now Windows-2022.
The fix for mbdetls has been merged. So we don't need an older macos
anymore. See #130.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
2 participants
@floitsch @kasperl