Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a single macro in the ARGS line of primitives to indicate a Windows path #1400

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Use a single macro in the ARGS line of primitives to indicate a Windows path #1400

merged 2 commits into from
Feb 6, 2023

Conversation

erikcorry
Copy link
Member

Instead of using argv[0] to get the executable.

@erikcorry
Use explicit executable name when forking on Windows
8346db4 
Instead of using argv[0] to get the executable.
@cla-bot cla-bot bot added the cla-signed The contributors have signed the CLA label Feb 3, 2023
@erikcorry erikcorry changed the title Use explicit executable name when forking on Windows Use a single macro in the ARGS line of primitives to indicate a Windows path Feb 3, 2023
floitsch
floitsch approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@floitsch floitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@erikcorry erikcorry mentioned this pull request Feb 3, 2023
Open
@erikcorry erikcorry merged commit 5038479 into master Feb 6, 2023
@erikcorry erikcorry deleted the fork-on-windows-use-command branch February 6, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floitsch floitsch floitsch approved these changes

Assignees
No one assigned
Labels
cla-signed The contributors have signed the CLA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erikcorry @floitsch