Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type propagators truthy test #1980

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fix type propagators truthy test #1980

wants to merge 10 commits into from

Conversation

kasperl
Copy link
Member

@kasperl kasperl commented Dec 1, 2023

No description provided.

@cla-bot cla-bot bot added the cla-signed The contributors have signed the CLA label Dec 1, 2023
Comment on lines 1470 to 1498
if (receiver_is_null) {
// If we know the receiver is null, then we can always compute an
// answer. If the argument is any, we don't know if the result is
// true or false. Otherwise, the result is true if the argument
// is null and false if the argument is non-null.
if (argument_is_any) {
stack->push_bool(program);
} else {
stack->push_bool_specific(program, argument_is_null);
}
ret(propagator_, stack);
delete scope;
return;
}

if (argument_is_null) {
// The receiver isn't null, so if the argument is null we
// know that the result is false.
stack->push_bool_specific(program, false);
ret(propagator_, stack);
delete scope;
return;
} else if (argument_is_any) {
// The receiver isn't null, so unless we know the argument
// cannot be null, we must add both true and false to the
// result but continue analyzing the method.
stack->push_bool(program);
ret(propagator_, stack);
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (receiver_is_null) {
// If we know the receiver is null, then we can always compute an
// answer. If the argument is any, we don't know if the result is
// true or false. Otherwise, the result is true if the argument
// is null and false if the argument is non-null.
if (argument_is_any) {
stack->push_bool(program);
} else {
stack->push_bool_specific(program, argument_is_null);
}
ret(propagator_, stack);
delete scope;
return;
}
if (argument_is_null) {
// The receiver isn't null, so if the argument is null we
// know that the result is false.
stack->push_bool_specific(program, false);
ret(propagator_, stack);
delete scope;
return;
} else if (argument_is_any) {
// The receiver isn't null, so unless we know the argument
// cannot be null, we must add both true and false to the
// result but continue analyzing the method.
stack->push_bool(program);
ret(propagator_, stack);
}
if (argument_is_any) {
stack->push_bool(program);
ret(propagator_, stack);
if (receiver_is_null) {
delete scope;
return;
}
} else if (receiver_is_null || argument_is_null) {
stack->push_bool_specific(program, receiver_is_null && argument_is_null);
ret(propagator_, stack);
delete scope;
return;
}

Copy link
Member

@erikcorry erikcorry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there's a test failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The contributors have signed the CLA
Development

Successfully merging this pull request may close these issues.

None yet

2 participants