Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Or 1446 titan canyon upgrade sdk to supply portal deposit and passer withdrawal #116

Merged
merged 17 commits into from
Apr 5, 2024
Merged

Or 1446 titan canyon upgrade sdk to supply portal deposit and passer withdrawal #116

merged 17 commits into from
Apr 5, 2024

Conversation

nguyenzung
Copy link
Member

@nguyenzung nguyenzung commented Apr 4, 2024 •
edited
Loading

Upgrade SDK to

  • deposit via OptimismPortal
  • withdraw via L2ToL1MessagePassed

Added interfaces: packages/tokamak/sdk/src/portals.ts

  • depositTransaction(): deposit to L2 by using OptimismPortal
  • waitingDepositTransactionRelayed()
  • initiateWithdrawal(): create a withdrawal transaction by using L2ToL1MessagePasser
  • waitForWithdrawalTxReadyForRelay():
  • waitForWithdrawalTxReadyForRelayUsingL2Tx()
  • proveWithdrawalTransaction()
  • proveWithdrawalTransactionUsingL2Tx()
  • waitForFinalization()
  • waitForFinalizationUsingL2Tx()
  • finalizeWithdrawalTransaction()
  • finalizeWithdrawalTransactionUsingL2Tx()

There are some example tasks. We can refer it as examples of how to use the new interfaces

Thank you!

@nguyenzung nguyenzung self-assigned this Apr 4, 2024
@nguyenzung
OR-1446 query portals's info
c6e9e9d
@nguyenzung
OR-1446 update predeployed contracts
d50850b
@nguyenzung
OR-1446 calculate relayed deposit transaction hash on L2
8daca95
@nguyenzung
OR-1446 update source hash
7d91d7c
@nguyenzung
OR-1446 add Deposit type
f834685
@nguyenzung
OR-1446 add portals
465c845
@nguyenzung
OR-1446 add test task for deposit case
16642f6
@nguyenzung
OR-1446 add withdrawal message and calculation method
6d43a56
@nguyenzung
OR-1446 add prove for sdk's portal
e662205
@nguyenzung
OR-1446 add test task for proving withdrawal transaction by using sdk…
0c71279 
…'s portals
@nguyenzung
OR-1446 add support for finalize withdraw
059c9a4
@nguyenzung
OR-1446 remove log]
68bca65
@nguyenzung
OR-1446 update test task for withdrawal transaction
309cc55
@nguyenzung
OR-1446 add new calculation method for withdrawal message
16921a7
@nguyenzung
OR-1446 update sdk for withdrawal cases
c8ecded
@nguyenzung
OR-1446 add one more test task for withdrawal case
d645659
@nguyenzung nguyenzung force-pushed the OR-1446-titan-canyon-upgrade-sdk-to-supply-Portal-deposit-and-Passer-withdrawal branch from 64b44da to d645659 Compare April 4, 2024 08:09
@nguyenzung nguyenzung force-pushed the OR-1446-titan-canyon-upgrade-sdk-to-supply-Portal-deposit-and-Passer-withdrawal branch from afd4b6d to 2dcaa9c Compare April 4, 2024 08:33
rlgns98kr
rlgns98kr approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@rlgns98kr rlgns98kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you create nice, kind code so quickly?

Thank you very much! 🥰😍

@nguyenzung
Copy link
Member Author

How do you create nice, kind code so quickly?

Thank you very much! 🥰😍

Thank you very much, Steven

I tried to follow the convention and the convention is nice ^^

@nguyenzung nguyenzung merged commit 09f8bd4 into OR-1257-Update-smart-contracts-for-deposit-TON-in-L1 Apr 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlgns98kr rlgns98kr rlgns98kr approved these changes

@boohyung boohyung Awaiting requested review from boohyung

@AaronLee22 AaronLee22 Awaiting requested review from AaronLee22

@0x6e616d 0x6e616d Awaiting requested review from 0x6e616d

@ohbyeongmin ohbyeongmin Awaiting requested review from ohbyeongmin

@praveen263112 praveen263112 Awaiting requested review from praveen263112

@xxeonge xxeonge Awaiting requested review from xxeonge

Assignees

@nguyenzung nguyenzung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nguyenzung @rlgns98kr