Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests take a long time to launch (node probing delays) #169

Closed
wants to merge 1 commit into from
Closed

Tests take a long time to launch (node probing delays) #169

wants to merge 1 commit into from

Conversation

ysoftware
Copy link
Contributor

@ysoftware ysoftware commented Jun 7, 2019

  • What is the current behavior? (You can also link to an open issue here)
    It takes around 15 seconds for the tests to begin.

  • What is the new behavior (if this is a feature change)?
    It takes less than 5 seconds for the tests to begin.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:
    (using nodeos v1.7.3)
    After some update eosfactory became insufferably slow to launch.
    After doing some research on why that might be, I've found that node probing was taking way too long.
    I've played around with those 2 numbers and picked them by the best results for my case.
    Now the test begins on block 8 (which is ~4.5 seconds) instead of block 30.

I have to say that I'm not exactly sure why these numbers were chosen initially and how this will affect eosfactory running on other devices.
I only have my macbook to test it and exact change should be tested before publishing.
I just want to bring this problem to light: waiting 15 seconds to start the test is unacceptable.

@ysoftware ysoftware changed the title Wait less before and between probing the node Tests take a long time to launch Jun 7, 2019
@ysoftware ysoftware changed the title Tests take a long time to launch Tests take a long time to launch (node probing delays) Jun 7, 2019
Copy link
Contributor

@stefanzarembinski stefanzarembinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A agree, the current setup is too restrictive. It could be released, but ...
The current nodeos startup process is annoying: nodeos gets stuck. The starting algorithm has to be ready for both, stack conditions and other error conditions. No it cannot differentiate the conditions, and, therefore, it is over-cautious.

In the new edition, it will be improved. With stuck conditions detected early, it will be persistent restarting.

Hence, now, there is now room for the optimization that you propose

@jakub-zarembinski
Copy link
Contributor

Thank you for your contribution.
This problem has been fixed in the v3.2.0 release, so we're closing this PR without merging.

@ysoftware ysoftware deleted the patch-2 branch June 25, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants