fix : permissable passing of date for generic versioned storage (#1736)

.vscode/launch.json

@@ -40,6 +40,20 @@
       "console": "integratedTerminal",
       "cwd": "${workspaceFolder}/token-transformer",
       "internalConsoleOptions": "neverOpen"
+    },
+    {
+      "name": "Test current file",
+      "type": "node",
+      "request": "launch",
+      "runtimeExecutable": "${workspaceRoot}/node_modules/.bin/jest",
+      "args": [
+        "--testPathPattern=${fileBasenameNoExtension}",
+        "--no-cache",
+        "--coverage=false"
+      ],
+      "cwd": "${workspaceFolder}",
+      "sourceMaps": true,
+      "console": "integratedTerminal"
     }
   ]
 }

package.json

@@ -105,7 +105,7 @@
     "set-value": "^3.0.2",
     "storyblok-js-client": "^3.3.1",
     "use-debounce": "^6.0.1",
-    "zod": "^3.14.4"
+    "zod": "^3.21.4"
   },
   "devDependencies": {
     "@babel/core": "^7.12.16",

src/storage/GenericVersionedStorage.ts

@@ -12,7 +12,7 @@ const genericVersionedSchema = singleFileSchema.extend({
   values: z.record(tokensMapSchema),
   version: z.string().optional(),
   $themes: z.array(themeObjectSchema).optional(),
-  updatedAt: z.number().optional(),
+  updatedAt: z.coerce.date().optional(),
 });
 
 type GenericVersionedMeta = {
@@ -139,9 +139,9 @@ export class GenericVersionedStorage extends RemoteTokenStorage<GenericVersioned
     if (response.ok) {
       const parsedJsonData = await response.json();
       const validationResult = await genericVersionedSchema.safeParseAsync(parsedJsonData);
-
       if (validationResult.success) {
         const GenericVersionedData = validationResult.data as unknown as GenericVersionedData;
+        GenericVersionedData.updatedAt = (GenericVersionedData.updatedAt as unknown as Date).toISOString();
         return this.convertGenericVersionedDataToFiles(GenericVersionedData);
       }
     }

src/storage/__tests__/GenericVersionedStorage.test.ts

@@ -50,12 +50,14 @@ describe('GenericVersionedStorage', () => {
   });
 
   it('can read GenericVersioned data', async () => {
+    const unixTime = 1666785400000;
+    const date = new Date(unixTime);
     mockFetch.mockImplementationOnce(() => (
       Promise.resolve({
         ok: true,
         json: () => Promise.resolve({
           version: '1',
-          updatedAt: 1666785400000,
+          updatedAt: unixTime,
           values: {
             global: {
               colors: {
@@ -96,7 +98,73 @@ describe('GenericVersionedStorage', () => {
       path: '$metadata.json',
       data: {
         version: '1',
-        updatedAt: 1666785400000,
+        updatedAt: date.toISOString(),
+      },
+    });
+    expect(result[2]).toEqual({
+      type: 'tokenSet',
+      path: 'global.json',
+      name: 'global',
+      data: {
+        colors: {
+          red: {
+            type: TokenTypes.COLOR,
+            value: '#ff0000',
+          },
+        },
+      },
+    });
+  });
+
+  it('can parse date as an iso string', async () => {
+    const date = new Date(1666785400000);
+    mockFetch.mockImplementationOnce(() => (
+      Promise.resolve({
+        ok: true,
+        json: () => Promise.resolve({
+          version: '1',
+          updatedAt: date.toISOString(),
+          values: {
+            global: {
+              colors: {
+                red: {
+                  type: TokenTypes.COLOR,
+                  value: '#ff0000',
+                },
+              },
+            },
+          },
+          $themes: [
+            {
+              id: 'light',
+              name: 'Light',
+              selectedTokenSets: {},
+            },
+          ],
+        }),
+      })
+    ));
+
+    const storage = new GenericVersionedStorage(url, GenericVersionedStorageFlow.READ_WRITE_CREATE, defaultHeaders);
+    const result = await storage.read();
+
+    expect(result[0]).toEqual({
+      type: 'themes',
+      path: '$themes.json',
+      data: [
+        {
+          id: 'light',
+          name: 'Light',
+          selectedTokenSets: {},
+        },
+      ],
+    });
+    expect(result[1]).toEqual({
+      type: 'metadata',
+      path: '$metadata.json',
+      data: {
+        version: '1',
+        updatedAt: date.toISOString(),
       },
     });
     expect(result[2]).toEqual({