Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add rq workers to scan databases #82

Merged
merged 2 commits into from
Oct 23, 2021
Merged

Conversation

vrajat
Copy link
Member

@vrajat vrajat commented Oct 23, 2021

Database scan can take a long time. Since scans were part of the API
request, they can cause API timeout. Offload scans to workers.

rq is used for managing background workers.

Fix #80

Database scan can take a long time. Since scans were part of the API
request, they can cause API timeout. Offload scans to workers.

rq is used for managing background workers.

Fix tokern#80
@codecov
Copy link

codecov bot commented Oct 23, 2021

Codecov Report

Merging #82 (5ed3481) into master (53e2fcf) will decrease coverage by 0.79%.
The diff coverage is 55.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   83.36%   82.57%   -0.80%     
==========================================
  Files           8        9       +1     
  Lines        1082     1136      +54     
  Branches      105      108       +3     
==========================================
+ Hits          902      938      +36     
- Misses        148      166      +18     
  Partials       32       32              
Impacted Files Coverage Δ
data_lineage/__main__.py 0.00% <0.00%> (ø)
data_lineage/server.py 66.14% <50.00%> (+0.66%) ⬆️
data_lineage/__init__.py 80.90% <57.14%> (-1.35%) ⬇️
data_lineage/worker.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53e2fcf...5ed3481. Read the comment docs.

@vrajat vrajat merged commit 8b8266c into tokern:master Oct 23, 2021
@vrajat vrajat deleted the rq branch October 23, 2021 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nginx is timing out because scan takes a long time.
1 participant