-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redshift catalog extract #23
Comments
I guess 'table_schema' in where clause seems to be fine as its going to be used to query against catalog tables, column 'schema' is being returned by RedshiftMetadataExtractor |
Good catch. Thanks for pointing this out. I am not sure how I missed this when I tested with Redshift. This is also true for postgres and mysql. However postgres and mysql do not have unions or joins in their SQL queries w.r.t to schema and the extractors worked silently. @dhuettenmoser or @siva-mudiyanur , do you have access to a redshift database that you can test fix with? |
I just tested using "schema" for postgres and mysql. The change does not work because postgres does not support alias in where clause. |
I've only tested against redshift. I modified the local library file in order to get the redshift extraction to work, and changed that line to WHERE SCHEMA NOT IN ('information_schema', 'pg_catalog') |
Got it. Will you be able to test a patch version? I can release 0.5.4 with this fix. I will not be able to test redshift support for a few more days. |
yes, I can test that out. |
Potential fix for tokern#23
I've released v0.5.3. Can you check if that fixes this bug? |
Thanks for making that adjustment! I'll test it out in the morning to verify. |
I may not get a chance to test soon but I would definitely make sure to test by end of this week |
This fix works in my case. Thanks! |
Thanks. I'll close this ticket. @siva-mudiyanur if you can confirm, I'll be grateful. |
Hi @vrajat ..I've been getting errors when I try to update the package since the issue is fixed, am I missing something or package versions needs to be loosened up in the code?
|
dbcat/dbcat/catalog/db.py
Line 175 in 938c5af
in dbcat.catalog.db line 175 should be: WHERE SCHEMA NOT IN ('information_schema', 'pg_catalog')
this supplemental where clause is added after the extractor renames the table_schema columns to schema
The text was updated successfully, but these errors were encountered: